-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register empty validators for some MAXAR and VRICON extensions #330
Conversation
Register an empty validator for MAXAR_content_3tz. The extension does not have any properties to be validated
Register an empty validator for MAXAR_content_geojson. The extension does not have any properties to be validated
Register empty validators for VRICON_class and VRICON_grid.
baab08c
to
b16e511
Compare
There is a part that registers empty validators for (Note: Maybe the intention here was to follow the pattern of But... this is related to #231 . Namely insofar that validating a tileset that declares
I have some ideas for how this could be addressed, and will open a PR for this soon. The other empty validators are for However, I saw |
Regarding Of course a better solution would be to actually validate this object as well. |
I see, I should have checked the spec of The handling of GeoJSON in general is a bit tricky: Right now, using It is not clear whether an "unknown/unhandled" content type should trigger a warning (or maybe just an info?). There is a small comment in the respective code part about that, suggesting that it could make sense to make this configurable somehow. (Note: Actually implementing a full-fledged GeoJSON validator is not in the scope of the 3D Tiles Validator. But of course, it could make sense to pull in a third-party validator for that. Quick searches suggest that there are GeoJSON validation libraries, but I have not yet investigated which one could be the most suitable here). I have created a follow-up PR for this one at #331 If you have any preferences about how to handle |
No description provided.